fix(queue): surface a finding when capture-unobtainable degrades the screenshot-table gate - #10256
Conversation
…screenshot-table gate maybeAddScreenshotTableAdvisoryFinding early-returned on any action other than "advisory", so a close/block gate degraded by the JSONbored#9881 capture-unobtainable check never appended a finding anywhere -- the close/hold comment that would have said so doesn't fire on the degraded path either, leaving the maintainer with no visibility that their gate is unsatisfiable. Thread captureUnobtainable into the function and its evaluateScreenshotTableGate call, and only early- return on a non-advisory action once enforcement wasn't degraded.
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 14:41:19 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10256 +/- ##
==========================================
+ Coverage 80.60% 81.38% +0.77%
==========================================
Files 283 284 +1
Lines 59101 62589 +3488
Branches 7000 8286 +1286
==========================================
+ Hits 47641 50937 +3296
- Misses 11167 11234 +67
- Partials 293 418 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix(queue): surface a finding when capture-unobtainable degrades the screenshot-table gate
maybeAddScreenshotTableAdvisoryFinding early-returned on any action other than
"advisory", so a close/block gate degraded by the #9881 capture-unobtainable
check never appended a finding anywhere -- the close/hold comment that would
have said so doesn't fire on the degraded path either, leaving the maintainer
with no visibility that their gate is unsatisfiable. Thread captureUnobtainable
into the function and its evaluateScreenshotTableGate call, and only early-
return on a non-advisory action once enforcement wasn't degraded.
Closes #10060